Skip to content

Document limitation of Serial1.begin() config value for Nano 33 BLE boards #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Document limitation of Serial1.begin() config value for Nano 33 BLE boards #781

merged 1 commit into from
Oct 15, 2020

Conversation

per1234
Copy link
Collaborator

@per1234 per1234 commented Sep 24, 2020

Add a warning that use of any Serial1.begin() config value other than SERIAL_8N1 on the Arduino Nano 33
BLE boards will cause an Mbed OS crash.

Reference: arduino/ArduinoCore-mbed#60 (comment)


NOTE: Work is in progress to lift this limitation: ARMmbed/mbed-os#13665. Once that fix has been made, pulled into arduino-beta:mbed boards platform, and a release of that boards platform made with the fix, this commit should be reverted.

@per1234 per1234 requested a review from kengdahl September 24, 2020 16:47
@per1234 per1234 marked this pull request as draft September 25, 2020 10:16
@per1234 per1234 marked this pull request as ready for review September 25, 2020 10:36
@per1234 per1234 changed the title Document limitation of Serial.begin() config value for Nano 33 BLE boards Document limitation of Serial1.begin() config value for Nano 33 BLE boards Sep 25, 2020
@alranel
Copy link
Contributor

alranel commented Oct 13, 2020

I'd just suggest to remove the second sentence for two reasons: people are not aware of this thing called "Mbed OS" (we'd need to give more context) and, also, in a reference it's not common pattern to explain what happens if you don't follow the reference :)

…oards

Add a warning that use of any Serial1.begin() config value other than SERIAL_8N1 on the Arduino Nano 33
BLE boards will cause an Mbed OS crash.
@per1234
Copy link
Collaborator Author

per1234 commented Oct 13, 2020

OK, done. Thanks @alranel

@kengdahl kengdahl merged commit b26ac38 into arduino:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants